feat: Single-word `Array` abstraction #2203

mmagician · 2025-12-19T15:31:51Z

We eventually want to have double-word arrays & double-word queues. Once we agreed on the structure and where the files live, it's going to be trivial to extend to double-word array. A queue will require an extra storage slot to hold the metadata, though.

Features:

add a simple wrapper over storage map, s.t. the map keys are [index, 0, 0, 0]
export procedures set(slot_id_prefix: felt, slot_id_suffix: felt, index: Felt, VALUE: Word) -> OLD_VALUE: Word & get(slot_id_prefix: felt, slot_id_suffix: felt, index: Felt) -> VALUE: Word
tests that show how other account components have an easy interface for operating on the array

Usage:

use miden::core::word
use miden::standards::data_structures::array

const ARRAY_SLOT = word("test::array::data")

#! Wrapper for array::get that uses exec internally.
#! Inputs:  [index, pad(15)]
#! Outputs: [VALUE, pad(12)]
pub proc test_get
    push.ARRAY_SLOT[0..2]
    exec.array::get
end

#! Wrapper for array::set that uses exec internally.
#! Inputs:  [index, VALUE, pad(11)]
#! Outputs: [OLD_VALUE, pad(12)]
pub proc test_set
    push.ARRAY_SLOT[0..2]
    exec.array::set
end

let data_slot = StorageSlotName::new("test::array::data").unwrap();

// Create the wrapper account component
let wrapper_component = AccountComponent::new(
    wrapper_library.clone(),
    vec![StorageSlot::with_map(
        data_slot.clone(),
        StorageMap::with_entries([(
            Word::from([Felt::ZERO, Felt::ZERO, Felt::ZERO, Felt::ZERO]),
            Word::from([42u32, 42, 42, 42]),
        )])?,
    )],
)?
.with_supports_all_types();

mmagician · 2025-12-19T17:18:43Z

@copilot add change log entry for this PR 2203

Copilot · 2025-12-19T17:18:56Z

@mmagician I've opened a new pull request, #2204, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

This PR introduces a single-word Array account component that provides a simple, reusable array data structure for Miden accounts. The implementation wraps a StorageMap where array indices are mapped to keys of the form [index, 0, 0, 0].

Key changes:

Added Array struct with methods for creating arrays with initial elements or from slices
Implemented MASM procedures (get and set) for array access with configurable storage slots
Added comprehensive unit tests and integration tests demonstrating the component's usage

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`crates/miden-standards/src/account/array.rs`	Core implementation of the Array component with constructors, MASM generation, and conversion to AccountComponent
`crates/miden-standards/asm/account_components/array.masm`	MASM template defining `get` and `set` procedures for array operations
`crates/miden-standards/src/account/mod.rs`	Adds array module to the account components public API
`crates/miden-testing/src/kernel_tests/tx/test_array.rs`	Integration test verifying get/set operations work correctly in transaction context
`crates/miden-testing/src/kernel_tests/tx/mod.rs`	Includes the new test module
`CHANGELOG.md`	Documents the addition of the Array component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/miden-standards/asm/account_components/array.masm

crates/miden-standards/src/account/array.rs

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/miden-standards/asm/account_components/array.masm

crates/miden-standards/asm/standards/data_structures/array.masm

crates/miden-standards/asm/account_components/array.masm

partylikeits1983 · 2026-01-05T15:31:15Z

Looks great! This is a great feature!

When reviewing the implementation, it reminded me of this issue for KEY => vec![] issue I opened: #2085

crates/miden-standards/asm/account_components/array.masm

Fumuran

Looks good! Aside from the decision of whether we need to make this component a utility, I have just a small style nit inline.

crates/miden-standards/asm/standards/data_structures/array.masm

chore: simplify test chore: be explicit about padding

* Initial plan * chore: add changelog entry for PR 2203 Co-authored-by: mmagician <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mmagician <[email protected]>

Co-authored-by: Andrey Khmuro <[email protected]>

chore: remove component code

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/miden-testing/src/kernel_tests/tx/test_array.rs

Co-authored-by: Copilot <[email protected]>

mmagician force-pushed the mmagician-array-via-map branch from 505aa25 to 5479b77 Compare December 19, 2025 15:35

Copilot AI mentioned this pull request Dec 19, 2025

chore: add changelog entry for Array component #2204

Merged

mmagician force-pushed the mmagician-array-via-map branch 2 times, most recently from b5f4cdb to e708a51 Compare January 5, 2026 10:33

mmagician requested a review from Copilot January 5, 2026 10:33

Copilot started reviewing on behalf of mmagician January 5, 2026 10:34 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

crates/miden-standards/asm/account_components/array.masm Outdated Show resolved Hide resolved

crates/miden-standards/src/account/array.rs Outdated Show resolved Hide resolved

mmagician marked this pull request as ready for review January 5, 2026 12:35

mmagician requested a review from Copilot January 5, 2026 12:35

Copilot started reviewing on behalf of mmagician January 5, 2026 12:36 View session

mmagician requested review from Fumuran and partylikeits1983 January 5, 2026 12:37

Copilot AI reviewed Jan 5, 2026

View reviewed changes

crates/miden-standards/asm/account_components/array.masm Outdated Show resolved Hide resolved

crates/miden-standards/asm/standards/data_structures/array.masm Show resolved Hide resolved

partylikeits1983 approved these changes Jan 5, 2026 •

edited

Loading

View reviewed changes

partylikeits1983 reviewed Jan 5, 2026

View reviewed changes

crates/miden-standards/asm/account_components/array.masm Outdated Show resolved Hide resolved

mmagician requested a review from PhilippGackstatter January 7, 2026 11:31

bobbinth reviewed Jan 8, 2026

View reviewed changes

crates/miden-standards/asm/account_components/array.masm Outdated Show resolved Hide resolved

Fumuran reviewed Jan 13, 2026

View reviewed changes

crates/miden-standards/asm/standards/data_structures/array.masm Show resolved Hide resolved

mmagician mentioned this pull request Jan 14, 2026

AggLayer: implement verify_leaf #2277

Open

mmagician and others added 8 commits January 17, 2026 10:02

feat: working array

6f03672

chore: simplify test chore: be explicit about padding

chore: add changelog entry for Array component (#2204)

e136d3c

* Initial plan * chore: add changelog entry for PR 2203 Co-authored-by: mmagician <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mmagician <[email protected]>

fix: set_map_item no longer returns old root

c1c788d

chore: change Try to TryFrom for AccountComponent

05b5234

chore: correct the docs

aa50de3

chore: masm doc corrections

d04e396

chore: use BeWord instead of Word

17d96bf

chore: adjust masm comment about max len

2d34da0

mmagician and others added 2 commits January 17, 2026 10:04

Update crates/miden-standards/asm/account_components/array.masm

cff5982

Co-authored-by: Andrey Khmuro <[email protected]>

chore: turn array into utility

6bd6069

chore: remove component code

mmagician force-pushed the mmagician-array-via-map branch from 34ccf83 to 6bd6069 Compare January 17, 2026 10:04

mmagician added 3 commits January 17, 2026 10:23

chore: lint, simplify test & comments

3ff3c49

chore: remove unnecessary comments

0c37ba3

chore: remove duplicated changelog entry

ab2ca4d

mmagician changed the title ~~feat: Single-word Array component~~ feat: Single-word Array abstraction Jan 17, 2026

mmagician requested a review from bobbinth January 17, 2026 10:53

mmagician mentioned this pull request Jan 17, 2026

feat: double-word Array abstraction #2299

Open

mmagician requested review from Copilot and partylikeits1983 January 17, 2026 12:12

Copilot started reviewing on behalf of mmagician January 17, 2026 12:13 View session

Copilot AI reviewed Jan 17, 2026

View reviewed changes

Apply suggestions from code review

8a1fa90

Co-authored-by: Copilot <[email protected]>

partylikeits1983 approved these changes Jan 21, 2026

View reviewed changes

feat: Single-word Array abstraction #2203

Are you sure you want to change the base?

feat: Single-word Array abstraction #2203

Uh oh!

Conversation

mmagician commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmagician commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

partylikeits1983 commented Jan 5, 2026

Uh oh!

Uh oh!

Fumuran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: Single-word `Array` abstraction #2203

feat: Single-word `Array` abstraction #2203

mmagician commented Dec 19, 2025 •

edited

Loading